Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SetExpectationsForUsers flag #4968

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Aug 21, 2024

References:

Jira: MNTOR-3543
Figma:

Description

This is a followup to #4854, removing the SetExpectationsForUsers flag, now that it's been enabled.

How to test

We shouldn't mention the 7-14-day period anymore. (Even though it was prefixed by "typically", it was still a surprise if removals took longer.)

Checklist (Definition of Done)

  • Localization strings (if needed) have been added removed.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Aug 21, 2024
@Vinnl Vinnl requested review from codemist and flozia August 21, 2024 13:56
@Vinnl Vinnl self-assigned this Aug 21, 2024
@Vinnl Vinnl requested a review from flodolo as a code owner August 21, 2024 13:56
Copy link

@Vinnl Vinnl force-pushed the MNTOR-3543-remove-SetExpectationsForUsers branch from 5eebee4 to 00d63f0 Compare August 22, 2024 10:10
Copy link
Collaborator

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vinnl Vinnl merged commit d0f8b45 into main Aug 26, 2024
15 checks passed
@Vinnl Vinnl deleted the MNTOR-3543-remove-SetExpectationsForUsers branch August 26, 2024 16:03
Copy link

Cleanup completed - database 'blurts-server-pr-4968' destroyed, cloud run service 'blurts-server-pr-4968' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants