Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

Handling auto-disable pref situations #2

Closed
thomaselin opened this issue May 1, 2018 · 4 comments
Closed

Handling auto-disable pref situations #2

thomaselin opened this issue May 1, 2018 · 4 comments
Assignees

Comments

@thomaselin
Copy link

Just wondering how this process would work when a feature is enabled by default in Nightly but set to auto-disable in Beta/Release? The Layout team commonly uses this tactic to test new features in Nightly and gather feedback.

When the feature is ready they then land a bug that removes the auto-disable and let's the feature ride the trains pref'd ON by default.

Example; Shapes outside
layout.css.shape-outside.enabled
Bug to enable in Nightly only (https://bugzilla.mozilla.org/show_bug.cgi?id=1353631)
Bug filed to remove auto-disable in Beta and Release (https://bugzilla.mozilla.org/show_bug.cgi?id=1457297)

@emceeaich
Copy link
Contributor

emceeaich commented May 1, 2018 via email

@pascalchevrel
Copy link
Member

And we don't use a feature flag server for this, we set the prefs in the build?

yes, the channel specific build-defines are documented here:
https://wiki.mozilla.org/Platform/Channel-specific_build_defines

@emceeaich
Copy link
Contributor

@thomaselin, I'm going to draft a PR which tries to describe this workflow, cribbing from your description, and ask for your review.

@emceeaich
Copy link
Contributor

I'm going to close this as this version of the Features Flags work is obsoleted by the Feature Tracking work.

emceeaich added a commit that referenced this issue Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants