Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify all involved triagers when changing triage owners #2389

Merged
merged 12 commits into from
May 10, 2024
Merged

Notify all involved triagers when changing triage owners #2389

merged 12 commits into from
May 10, 2024

Conversation

benjaminmah
Copy link
Contributor

@benjaminmah benjaminmah commented May 9, 2024 •
edited by suhaibmujahid
Loading

PR to implement notifying all involved triagers when changing triage owners via email, resolves #1606.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

suhaibmujahid
suhaibmujahid reviewed May 9, 2024
View reviewed changes
bugbot/bzcleaner.py Outdated Show resolved Hide resolved
bugbot/bzcleaner.py Outdated Show resolved Hide resolved
bugbot/rules/triage_owner_rotations.py Outdated Show resolved Hide resolved
bugbot/rules/triage_owner_rotations.py Outdated Show resolved Hide resolved
bugbot/rules/triage_owner_rotations.py Outdated Show resolved Hide resolved
bugbot/rules/triage_owner_rotations.py Outdated Show resolved Hide resolved
bugbot/rules/triage_owner_rotations.py Show resolved Hide resolved
templates/triage_owner_rotations.html Outdated Show resolved Hide resolved
suhaibmujahid
suhaibmujahid reviewed May 9, 2024
View reviewed changes
bugbot/utils.py Outdated Show resolved Hide resolved
templates/triage_owner_rotations.html Outdated Show resolved Hide resolved
bugbot/utils.py Outdated Show resolved Hide resolved
bugbot/rules/triage_owner_rotations.py Outdated Show resolved Hide resolved
suhaibmujahid
suhaibmujahid reviewed May 10, 2024
View reviewed changes
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Benjamin!

Could you update the PR description to link it to resolving the target issue? Also, feel free to change the PR from "draft" to "Ready for review".

Finally, please check the aplicable items in the PR's checklist.

bugbot/utils.py Outdated Show resolved Hide resolved
bugbot/utils.py Outdated Show resolved Hide resolved
bugbot/utils.py Outdated Show resolved Hide resolved
bugbot/utils.py Outdated Show resolved Hide resolved
bugbot/utils.py Outdated Show resolved Hide resolved
bugbot/utils.py Outdated Show resolved Hide resolved
@benjaminmah benjaminmah changed the title Implement Triage Owner Notification Emails Notify all involved triagers when changing triage owners May 10, 2024
@benjaminmah benjaminmah marked this pull request as ready for review May 10, 2024 01:37
@suhaibmujahid suhaibmujahid added the to-be-announced Improvements to be announced: send to dev-platform, firefox-dev and add to EE newsletter label May 10, 2024
suhaibmujahid
suhaibmujahid approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@suhaibmujahid suhaibmujahid merged commit 283089a into mozilla:master May 10, 2024
2 checks passed
@suhaibmujahid suhaibmujahid linked an issue May 10, 2024 that may be closed by this pull request
Notify triage owners when performing a rotation #1606
Closed
@benjaminmah benjaminmah deleted the triage-email-notifications branch May 30, 2024 18:19
@suhaibmujahid suhaibmujahid added announced and removed to-be-announced Improvements to be announced: send to dev-platform, firefox-dev and add to EE newsletter labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhaibmujahid suhaibmujahid suhaibmujahid approved these changes

Assignees
No one assigned
Labels
announced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notify triage owners when performing a rotation
2 participants
@benjaminmah @suhaibmujahid