Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to python3 + cleanup #602

Merged
merged 6 commits into from
May 21, 2019
Merged

Migrate to python3 + cleanup #602

merged 6 commits into from
May 21, 2019

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Apr 23, 2019

Fixes #282.

@coveralls
Copy link

coveralls commented Apr 23, 2019

Coverage Status

Coverage decreased (-4.5%) to 25.985% when pulling 3eab2a2 on calixteman:python3 into 792aede on mozilla:master.

.travis.yml Show resolved Hide resolved
marco-c
marco-c previously approved these changes May 20, 2019
marco-c
marco-c previously approved these changes May 20, 2019
marco-c
marco-c previously approved these changes May 20, 2019
sylvestre
sylvestre previously approved these changes May 20, 2019
@sylvestre sylvestre dismissed their stale review May 20, 2019 14:13

ci errors

@sylvestre
Copy link
Contributor

      'f3': utils.get_flag(self.versions['release'], 'tracking', 'release'),
   TypeError: 'NoneType' object is not subscriptable

@sylvestre
Copy link
Contributor

please fix that

@marco-c
Copy link
Contributor

marco-c commented May 20, 2019

The error is in auto_nag/scripts/tracked_bad_severity.py:

   Traceback (most recent call last):
    auto_nag/tests/test_bzcleaner.py line 51 in test_get_bz_params
      p = TrackedBadSeverity().get_bz_params(None)
    auto_nag/scripts/tracked_bad_severity.py line 31 in get_bz_params
      'f3': utils.get_flag(self.versions['release'], 'tracking', 'release'),

@calixteman
Copy link
Contributor Author

The bug is because of non-following versions in p-d when the test ran yesterday. I'm fixing it.

@marco-c marco-c merged commit a941d4f into mozilla:master May 21, 2019
@calixteman calixteman deleted the python3 branch February 3, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Python 3
4 participants