-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delta request-merge #97
Conversation
bugbug/bug_features.py
Outdated
@@ -131,6 +134,12 @@ def __call__(self, bug): | |||
return any(bug['creator_detail']['email'].endswith(domain) for domain in ['@mozilla.com', '@mozilla.org']) | |||
|
|||
|
|||
class delta_request_merge(object): | |||
def __call__(self, bug): | |||
uplift_request_datetime = datetime.strptime(bug['history'][0]['when'], '%Y-%m-%dT%H:%M:%SZ').replace(tzinfo=timezone.utc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the date of the first modification to the bug, we should get the date of the first uplift request instead.
55 is the version of Firefox. You should calculate the difference between the uplift request date and the |
For the first uplift request, I'd have to iterate through |
Exactly, look at the uplift model for an example. |
Yep, that's where I saw this. After these changes, we get |
Yes, I think days would be good. |
Ok, everything gets converted to days now (I'm not sure why. but the travis test takes forever). Also, @marco-c small question: I just noticed that https://github.com/mozilla/bugbug/blob/master/bugbug/bug_features.py#L135 uses the |
The commit data is added to the bugs if you use Line 213 in b9bb067
|
bugbug/bug_features.py
Outdated
@@ -132,6 +135,18 @@ def __call__(self, bug): | |||
return any(bug['creator_detail']['email'].endswith(domain) for domain in ['@mozilla.com', '@mozilla.org']) | |||
|
|||
|
|||
class delta_request_merge(object): | |||
def __call__(self, bug): | |||
for change in bug['history']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Call this history
and ind_change
change
, to keep the same variable names as other parts of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Travis CI fails due to an error in |
The error should be gone if you rebase on top of current master. |
Changes proposed: A new bug_extractor, that returns the time difference between request date and merge date.
Example:
If I'm not wrong, 55 is the required delta here. (right?)
@marco-c Is this similar to what was required?