This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Allow non admins to request a loan #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling new_fr.validate() doesn't work if that file is not in the current directory, and anyway the digest is already calculated so there's nothing to validate. Files already in the manifest need not exist in the current directory, so they can't be validated either.
…bber The TokenUser is not anonymous, but also has no e-mail address associated with it. When this combination occurs, a who value of 'automation' should be supplied, instead of outright failing. While not exact, the term automation gives us a way to categorize clobbers that seemed to be authenticated by a permanent token (as opposed to a user token).
Bug 1164878 - Allow users without an authenticated_email field to clo…
|
Original review was on mozilla/build-relengapi-slaveloan#37 |
|
👍 per @djmitche on IRC. since "I see that as just a port of the already-merged code, so go ahead" |
Callek
added a commit
that referenced
this pull request
Jun 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @Callek on March 31, 2015 4:56
Copied from original issue: mozilla/build-relengapi-slaveloan#37