Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Make version parsing more robust. #20

Merged
merged 2 commits into from
Aug 19, 2015
Merged

Conversation

Uberi
Copy link
Contributor

@Uberi Uberi commented Aug 19, 2015

Previously, parsing broke on a change in the wiki page made in July - the minor version as the second row was removed.

We can now check all rows and use all the ones that match the expected format.

Previously, parsing broke on a change in the wiki page made in July - the minor version as the second row was removed. We can now check all rows and use all the ones that match the expected format.
is_valid = False
break
if not is_valid: continue

nightly_version = str(version_get_major(fields[-4].string.replace("Firefox ", ""))) + ".0a1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scraping for past and future release date tables should be refactored into a single function.

vitillo added a commit that referenced this pull request Aug 19, 2015
Make version parsing more robust.
@vitillo vitillo merged commit 8ca9e38 into mozilla:master Aug 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants