This repository has been archived by the owner on Sep 25, 2018. It is now read-only.
Fix for Issue #6 (first attempt) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… graph will no longer show a tracking link between sites A and B.
|
Oops, discovered a regression introduced by my previous changeset. Fixed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dethe,
Here's a first pass at a fix for bug 6. The tab.ready() listener now looks at the history of the tab -- if the last two sites are A and B, then it knows you navigated from A to B, and it adds the "user_navigation" datatype to that link. The grapher simply doesn't display any links with "user_navigation" as a datatype.
This is not strictly correct, since it's possible that something made a tracking connection between A and B AND the user manually navigated between them. The new behavior will be to not show the link, when really we would like to show it. But this is still better than nothing?
The way this is implemented is not the most elegant -- I had to dip into XPCOM to examine the tab history, and then interate through the simpleEnumerator to get all the items even though I only want the next-to-last one. If you know of a better way, I'm open to suggestions.
Manual test case: go to mozilla.com. Click the link to Twitter at the bottom of the page. Open the Collusion graph: observe there's no link from Mozilla to Twitter.