Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefereneces/options page #550

Open
WesleyBranton opened this issue Nov 23, 2019 · 9 comments · Fixed by #566
Open

Add prefereneces/options page #550

WesleyBranton opened this issue Nov 23, 2019 · 9 comments · Fixed by #566
Labels
enhancement New feature or request needs-priority This issue needs prioritization

Comments

@WesleyBranton
Copy link

WesleyBranton commented Nov 23, 2019

The users should be able to view and remove the allowed sites through the options UI. It's currently possible using the panel, but few users run with the Facebook Container browser action visible on their toolbar. Having that ability also built into the options UI would make it easier for users to find.

@WesleyBranton WesleyBranton changed the title Cannot remove domains added to the Facebook Container extension Add ability to edit allowed sites through options UI Nov 23, 2019
@maxxcrawford
Copy link
Collaborator

By Options UI, do you mean this? Facebook Container does not have an options page set/created as of yet.

@WesleyBranton
Copy link
Author

By Options UI, do you mean this? Facebook Container does not have an options page set/created as of yet.

Yes. Something more universal than the browserAction popup. Not every user has that saved to their toolbar.

@str
Copy link

str commented Dec 17, 2019

I don't see any way to allow a site. What "browserAction popup"? I don't see any popup? What panel?
(I'm not being sarcastic, I really don't see a way to add a site)

Please do add a way to add the site from a plugin config page.

@maxxcrawford
Copy link
Collaborator

@str The only way currently is through in-page UI on badged login buttons. (Example: imgur.com)

image

Follow #422 for progress on this issue.

@maxxcrawford
Copy link
Collaborator

@WesleyBranton I've added a preferences page as an feature to discuss in our next roadmapping meeting. Thanks!

@str
Copy link

str commented Dec 18, 2019

@str The only way currently is through in-page UI on badged login buttons.

In pages that load images from instagram, there is no "facebook container icon"

image

Should I paste that in the #422 or here?

@maxxcrawford
Copy link
Collaborator

@str Actually…I would post this into #520

@RVAUser
Copy link

RVAUser commented Dec 18, 2019

@str The only way currently is through in-page UI on badged login buttons. (Example: imgur.com)

image

Follow #422 for progress on this issue.

This image pop-up does not appear when I click on the icon in my browser. Instead, I get the following image
image

@maxxcrawford
Copy link
Collaborator

@RVAUser My pop-up was from clicking an on-page/in-content badge – not the panel/doorhanger.

@maxxcrawford maxxcrawford reopened this Feb 14, 2020
@maxxcrawford maxxcrawford changed the title Add ability to edit allowed sites through options UI Add prefereneces/options page Apr 6, 2020
@maxxcrawford maxxcrawford pinned this issue Apr 6, 2020
@maxxcrawford maxxcrawford added the enhancement New feature or request label Apr 6, 2020
@maxxcrawford maxxcrawford added the needs-priority This issue needs prioritization label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-priority This issue needs prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants