Fix #47 - Add stash support #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This by default generates an `mlbf` file named `filter.stash`, which contains all the additions to the filter, collated by issuer and status change. The file is made of per-issuer blocks, where each block's bytes are: bytes 0-3: N, number of revoked serials as an unsigned long bytes 4-7: M, number of nonrevoked serials as an unsigned long bytes 8-9: L, length of the issuer field as a unsigned short bytes 10+: hash of issuer subject public key info of length L ... then N serials_structs ... followed by M serials_structs The serials_struct blocks are defined: bytes 0-1: S, length of serial field as an unsigned short bytes 2+: ASN.1 DER-encoded serial number of length S When reaching EOF, there are no more issuer blocks. Consumers can collect these `filter.stash` files, load them in chronological order, and apply them before querying the originating MLBF filter.
mozkeeler
reviewed
Mar 6, 2020
|
Good catch, I'll adjust the documentation and the commit message. |
mozkeeler
approved these changes
Mar 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This by default generates an
mlbffile namedfilter.stash, which containsall the additions to the filter, collated by issuer and status change.
The file is made of per-issuer blocks, where each block's bytes are:
The serials_struct blocks are defined:
When reaching EOF, there are no more issuer blocks.
Consumers can collect these
filter.stashfiles, load them in chronologicalorder, and apply them before querying the originating MLBF filter.