Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the ruff config to include import sorting and others. #234

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

robhudson
Copy link
Member

No description provided.

Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robhudson! I like it when the robots point out issues, and love it when they can make the changes too.

@@ -85,13 +85,59 @@ include-package-data = true
[tool.setuptools.packages]
find = { namespaces = false }

[tool.ruff]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm glad to see us merging to pyproject.toml!

@@ -45,9 +47,9 @@
]


def migrate_settings() -> Tuple[Dict[str, Any], bool]:
def migrate_settings() -> tuple[dict[str, Any], bool]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that this is allowed with Python 3.8 with from __future__ import annotations

@@ -18,7 +20,7 @@ def _unquote(s: str) -> str:


@register.tag(name="script")
def script(parser: Parser, token: Token) -> "NonceScriptNode":
def script(parser: Parser, token: Token) -> NonceScriptNode:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@robhudson robhudson merged commit b348924 into main Jul 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants