Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Jared's rules to Fathom #12

Closed
erikrose opened this issue May 16, 2016 · 1 comment
Closed

Port Jared's rules to Fathom #12

erikrose opened this issue May 16, 2016 · 1 comment

Comments

@erikrose
Copy link
Contributor

Jared did a sketch of some extractors for Universal Search but based them on a much simpler, non-scoring, short-circuiting design with mixed rank and yank phases: https://github.com/JaredKerim-Mozilla/fathom/blob/master/fathom.js#L66. Port them to Fathom's current design, and bend our design to make them possible, if necessary. Short-circuiting isn't a blocker and would probably uglify our design. It's likely we can instead make the ranker functions more declarative and make the rule engine smart enough not to execute rules that couldn't possible win.

erikrose added a commit that referenced this issue May 17, 2016
His original ruleset: https://github.com/JaredKerim-Mozilla/fathom/blob/0e473db5d5c22fd6660f98b46e83f85d465a2e3a/fathom.js#L68-L71

It's wordy and inefficient, but it's a start.

Also, separate tests into actual tests and design-inspiring use cases so we don't obscure (minimal) tests with non-minimal stuff.
erikrose added a commit that referenced this issue May 19, 2016
@erikrose
Copy link
Contributor Author

Actually, all the Universal Search extractors are pretty similar. I think the one I ported sufficiently demonstrates that Fathom can handle that sort of thing. Feel free to reopen if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant