Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let out('smoo') be spelled as just 'smoo' #51

Closed
erikrose opened this issue Dec 20, 2016 · 5 comments
Closed

Let out('smoo') be spelled as just 'smoo' #51

erikrose opened this issue Dec 20, 2016 · 5 comments
Assignees

Comments

@erikrose
Copy link
Contributor

…for symmetry with facts.get('smoo').

@erikrose erikrose added this to the 2.0 milestone Dec 20, 2016
@erikrose erikrose modified the milestones: 2.x, 2.0, 2.1 Jan 26, 2017
@erikrose erikrose modified the milestone: 2.1 Apr 19, 2017
@danielhertenstein
Copy link
Collaborator

danielhertenstein commented Jun 28, 2019

Can you provide more detail? I've looked in the repo for out('smoo') and facts.get('smoo'), but don't see either anywhere.

@erikrose
Copy link
Contributor Author

Yes, sorry. "smoo" is just a placeholder, like "foo" or "bar". Translating from "Erik-ese", the intent of this ticket is to let rules like…

rule(type('foo').max(), out('bar'))

…be more concisely represented as…

rule(type('foo').max(), 'bar')

It should be a matter of "compiling" a RHS string down to out(theString) during ruleset or rule construction.

@danielhertenstein danielhertenstein self-assigned this Jul 26, 2019
@danielhertenstein
Copy link
Collaborator

Do we want to allow for rules to still be written the previous way? I think we'll have to so people can still do things like:

rule(dom('p'), out('para').through(fnode => fnode.element.tagName))

@erikrose
Copy link
Contributor Author

erikrose commented Jul 29, 2019 via email

@danielhertenstein
Copy link
Collaborator

Closed by #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants