Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

We should detect and discard Flickr 'image not found' images #9

Closed
davidascher opened this issue Sep 11, 2013 · 3 comments
Closed

We should detect and discard Flickr 'image not found' images #9

davidascher opened this issue Sep 11, 2013 · 3 comments
Assignees

Comments

@davidascher
Copy link
Contributor

sometimes flickr returns an image that's actually a placeholder. We should never show that image, and look for another.

@ghost ghost assigned clarkbw Sep 11, 2013
@clarkbw
Copy link
Contributor

clarkbw commented Sep 11, 2013

Not sure how to do this, but I'll take a look.

@davidascher
Copy link
Contributor Author

http://stackoverflow.com/questions/5488052/how-can-i-detect-when-flickr-photos-become-unavailable

suggests that permission are the root, which puzzles me as the search shouldn't find them. But http://www.flickr.com/services/api/flickr.photos.getPerms.html for reference.

@clarkbw
Copy link
Contributor

clarkbw commented Sep 16, 2013

What's happening is that we're requesting a photo size that doesn't exist. Currently we're always asking for a 'b' or 'Large' size photo but they don't always exist, see flickr urls; before 2010 these didn't always exist.

The only way to get the larger photo is to make an additional call to getSizes to ensure there exists a large (1024px) size photo.

For now I'm going to drop us down to the 'z' size (640) which is much more available, it will give us smaller pictures but should always return something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants