Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No underlined pipe | on hover #1153

Closed
wants to merge 44 commits into from
Closed

No underlined pipe | on hover #1153

wants to merge 44 commits into from

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Mar 6, 2018 •
edited

alanmoo and others added 30 commits February 8, 2018 22:07
@alanmoo @mmmavis
Set stage for fellowships pages w/ django template (#961)
1ae740e 
* Set stage for fellowships pages w/ django template
@ScottDowne @mmmavis
Adding some stub urls for the fellowships site. (#971)
bbc690a 
* Adding some stub urls for the fellowships site.

* Update some of the urls a bit more
@mmmavis
fellowships homepage wireframe (#965)
190dab9
@gideonthomas @mmmavis
Fix review apps for fellows (#1010)
a431764 
* Test commit

* Find out which url is it resolving to

* Fix stuff

* Remove debugging stuff
@mmmavis
fixed rebase conflicts
fc9171d
@mmmavis
Fellowships support page (#1006)
480d8d0 
Fellowships support page
@mmmavis
fixed rebase conflicts
4c93a42
@mmmavis
Responsive fellowships nav & better multi-page nav on mobile (#1020)
e50f89b 
* Related to #1019 - repsonsive fellowships nav + #977 - better multi-page nav on mobile
@mmmavis
Updated fellowships homepage (#1042)
207a8e2 
* updated fellowships homepage
@mmmavis
Merge branch 'master' into fellowships
a1a962c
@mmmavis
updated fellowships support page (#1049)
f95bd89
@mmmavis
Fellowships directory pages (#1046)
3456e4f 
* Related to #955 - fellowships directory pages
@mmmavis
Update fellowships type pages (#1059)
72b4b0b
@mmmavis
added illustration to fellowship types page and fellowships support p…
8c59646 
…age (#1061)
@mmmavis
Merge branch 'master' into fellowships
f30bf3d
@mmmavis
made fellowships work use the new master template (#1069)
8d95049
@mmmavis @alanmoo
updated /apply page so it's in 'application open' state (#1070)
248f3f3
@mmmavis
Merge branch 'master' into fellowships
db65e5b
@mmmavis
More assets (#1073)
f759e9f 
* added more assets & created a svg sub-folder

* added hero image to fellowships homepage
@mmmavis
Related to #1062 - hide affiliation meta from front end (#1075)
3215d6b
@mmmavis
Merge branch 'master' into fellowships
ebe55ef
@mmmavis
Merge branch 'master' into fellowships
cc11263
@mmmavis
Merge branch 'master' into fellowships
cb0a417
@mmmavis
design tweaks (#1081)
561a9ec 
* design tweaks
@mmmavis
show fellow location in fellowships directory (#1103)
ee7ae96
@mmmavis
Merge branch 'master' into fellowships
f8e3d4f
@alanmoo
Merge branch 'master' into fellowships
d8dbeac
@mmmavis
Added loading icon (#1093)
52605bd 
* Related to #1045 - added loading icon
@mmmavis
Featured fellows (#1112)
7874044 
* added featured fellows on fellowships homehomepomepage (hardcoded)
@mmmavis
hide some incomplete content for now (#1113)
c48e8fd
@mmmavis
Fixes #1092 - added back missing icon & ran task to optimize svgs (#1108
1d51aac 
)
@mmmavis
Added placeholder headshot to Person component (#1119)
f81827b 
* Related #1114 - added placeholder headshot
@mmmavis
Updated fellowships homepage content and layout again (#1122)
f0855d7 
* Related to #1120 - updated fellowships homepage content and layout again
* Related to #1124 - hero banner adjustment
@mmmavis
Fixed #1096 - replaced a svg (#1123)
b53641b
@mmmavis
Merge branch 'master' into fellowships
1e19ec9
@mmmavis
Content changes to apply page (#1127)
fe90bb1 
* Related to #1116 - content changes to apply page
@mmmavis
Fixed broken 'see work' link (#1129)
3ec4f3b 
* Fixed #1128 - fixed broken 'see work' link
@mmmavis
Fixes #1144 - fixed a fellow's social link (#1145)
90abe27
@mmmavis
Merge branch 'master' into fellowships
2512b7b
@mmmavis
remmoved 'senior fellow' section from directory pages (#1150)
ee784d0
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1153 March 6, 2018 00:03 Inactive
@mmmavis
redirected /fellowship to /fellowships (#1149)
0b7bf42 
* redirected /fellowship to /fellowships

* removed an extra line
@mmmavis
Fellowships improvements (#1157)
a743a0d 
* code improvement

* removed a few empty files
@mmmavis
Fixed #1151 - no underlined pipe | on hover
27a475e
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-1153 March 6, 2018 21:50 Inactive
taisdesouzalessa
taisdesouzalessa approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@taisdesouzalessa taisdesouzalessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect 💯 Tksss!

@mmmavis mmmavis changed the base branch from fellowships to master March 6, 2018 22:01
@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 6, 2018

fellwoships got merged into master already and it seems like changing the base branch from fellowships to master doesn't do the trick I was hoping to see. There are tons of commits in this PR now... which shouldn't be merged in. I'm gonna create a new PR based off of master. Closing this one now.

@mmmavis mmmavis closed this Mar 6, 2018
@mmmavis mmmavis mentioned this pull request Mar 6, 2018
Merged
@mmmavis mmmavis deleted the issue-1151-hover branch March 6, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taisdesouzalessa taisdesouzalessa taisdesouzalessa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmmavis @taisdesouzalessa @cadecairos @alanmoo @ScottDowne @gideonthomas