Fix test errors #61
Fix test errors #61
Conversation
| @@ -30,10 +30,12 @@ | |||
|
|
|||
| DATABASE_ROUTERS = ('multidb.PinningMasterSlaveRouter',) | |||
|
|
|||
| SITE_URL = '' | |||
There was a problem hiding this comment.
Apparently this is just for tests here. It's been removed as a thing from playdoh apparently. Maybe just mock this one too?
There was a problem hiding this comment.
Best would be if we could remove the need for that setting from tests here, but I've not looked at how hard that would be.
There was a problem hiding this comment.
If I remove this, the tests fail somehow even when there are @patch.object(settings, 'SITE_URL', 'http://testserver').
There was a problem hiding this comment.
Can you try to add it to the local.py when that file is written in tests/__init__.py then?
There was a problem hiding this comment.
I'm trying to keep this out because I remember other tools would use it if it existed. Not sure if those libs still exist, but this does have breakage potential if I'm remembering correctly.
There was a problem hiding this comment.
Adding SITE_URL = '' to .playdoh/funtestapp/project/settings/local.py-dist solved the issue. Will send a separate PR for that.
|
I wouldn't do that in Playdoh either. What I'm saying is that the funfactory test suite is already modifying that local.py as part of tests setup. Just add the settings programmatically there and the suite should pass. |
|
I got it. I could just add one line in |
|
The all tests passed. |
|
Nice! Works for me. Thanks @kyoshino 🍰 |
The tests passed locally with the
toxcommand.