As/search suggestion for engine selection #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soncuteanca
requested review from
sv-hyacoub,
sarinali,
Tracy-Walker,
ben-c-at-moz and
vsangereanMOZ
soncuteanca
changed the title
ben-c-at-moz
requested changes
Jun 18, 2024
tests/address_bar_and_search/test_suggestion_engine_selection.py
Outdated
Show resolved
Hide resolved
|
@soncuteanca I'm still getting a failure on the test when trying for Amazon.com -- perhaps it's actually looking for just "Amazon"? Not sure... |
ben-c-at-moz
requested changes
Jun 20, 2024
tests/address_bar_and_search/test_suggestion_engine_selection.py
Outdated
Show resolved
Hide resolved
tests/address_bar_and_search/test_suggestion_engine_selection.py
Outdated
Show resolved
Hide resolved
ben-c-at-moz
requested changes
Jun 21, 2024
|
One more thing, you're going to need to merge main before I'll be able to approve this one (not just resolve merge conflicts). Thanks! |
ben-c-at-moz
approved these changes
Jun 27, 2024
|
With the latest changes, I have achieved a 15/15 pass rate locally. Is there anything else I should do here? |
|
@soncuteanca No, you just needed to resolve all the conversations by pressing the "Resolve Conversation". It's good to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This verifies that when entering "@" in awesome bar, a list of search engines is suggested, and upon selecting an option, the search is performed using the selected engine.
Bugzilla bug ID
ID: 1902767
Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1902767
Type of change
Please delete options that are not relevant.
How does this resolve / make progress on that bug?
Finished
Screenshots / Explanations
Please upload any relevant media or add a relevant description with respect to the bug listed above.
Comments / Concerns
Please add a short blurb about any comments or concerns that this change might cause.