fix(sync): Remove support for context=fx_desktop_v2

Hot on the heels of #6895, it's now relatively pain
free to deprecate a context.

This deprecates `context=fx_desktop_v2` which hasn't
been used since Firefox 45, 20 versions ago.

Users will instead be prompted to upgrade their
Firefox.

fixes #7030

Author: Shane Tomlinson

app/scripts/lib/app-start.js

@@ -316,12 +316,8 @@ Start.prototype = {
   initializeAuthenticationBroker () {
     if (! this._authenticationBroker) {
       let context;
-      if (this._isFxDesktopV2()) {
-        if (this._isIframeContext()) {
-          context = Constants.FX_FIRSTRUN_V1_CONTEXT;
-        } else {
-          context = Constants.FX_DESKTOP_V2_CONTEXT;
-        }
+      if (this._isIframeContext() && this._isServiceSync()) {
+        context = Constants.FX_FIRSTRUN_V1_CONTEXT;
       } else if (this._isOAuth()) {
         context = this._chooseOAuthBrokerContext();
       } else {
@@ -663,16 +659,6 @@ Start.prototype = {
     return !! (service && compareToService && service === compareToService);
   },
 
-  _isFxDesktopV2 () {
-    // A user is signing into sync from within an iframe on a trusted
-    // web page. Automatically speak version 2 using WebChannels.
-    //
-    // A check for context=fx_desktop_v2 can be added when about:accounts
-    // is converted to use WebChannels.
-    return (this._isServiceSync() && this._isIframeContext()) ||
-           (this._isContext(Constants.FX_DESKTOP_V2_CONTEXT));
-  },
-
   _isContext (contextName) {
     return this._getContext() === contextName;
   },

app/scripts/models/auth_brokers/index.js

@@ -16,10 +16,6 @@ const AUTH_BROKERS = [
     context: Constants.FX_SYNC_CONTEXT,
     Constructor: require('../auth_brokers/fx-sync')
   },
-  {
-    context: Constants.FX_DESKTOP_V2_CONTEXT,
-    Constructor: require('../auth_brokers/fx-desktop-v2')
-  },
   {
     context: Constants.FX_DESKTOP_V3_CONTEXT,
     Constructor: require('../auth_brokers/fx-desktop-v3')

app/tests/spec/lib/app-start.js

@@ -10,7 +10,6 @@ define(function (require, exports, module) {
   const BaseBroker = require('models/auth_brokers/base');
   const Constants = require('lib/constants');
   const ErrorUtils = require('lib/error-utils');
-  const FxDesktopV2Broker = require('models/auth_brokers/fx-desktop-v2');
   const FxFennecV1Broker = require('models/auth_brokers/fx-fennec-v1');
   const FxFirstrunV1Broker = require('models/auth_brokers/fx-firstrun-v1');
   const FxFirstrunV2Broker = require('models/auth_brokers/fx-firstrun-v2');
@@ -324,16 +323,6 @@ define(function (require, exports, module) {
         });
       });
 
-      describe('fx-desktop-v2', () => {
-        it('returns an FxDesktopV2 broker if `context=fx_desktop_v2`', () => {
-          windowMock.location.search = Url.objToSearchString({
-            context: Constants.FX_DESKTOP_V2_CONTEXT
-          });
-
-          return testExpectedBrokerCreated(FxDesktopV2Broker);
-        });
-      });
-
       describe('fx-fennec-v1', () => {
         it('returns an FxFennecV1 broker if `context=fx_fennec_v1`', () => {
           windowMock.location.search = Url.objToSearchString({

app/tests/spec/models/auth_brokers/index.js

@@ -25,12 +25,6 @@ describe('models/auth_brokers/index', () => {
     assert.ok(VALID_TYPE.test(authBroker.prototype.type));
   });
 
-  it('get returns correct broker for desktop-v2 context', () => {
-    const authBroker = index.get(constants.FX_DESKTOP_V2_CONTEXT);
-    assert.equal(authBroker, require('models/auth_brokers/fx-desktop-v2'));
-    assert.ok(VALID_TYPE.test(authBroker.prototype.type));
-  });
-
   it('get returns correct broker for desktop-v3 context', () => {
     const authBroker = index.get(constants.FX_DESKTOP_V3_CONTEXT);
     assert.equal(authBroker, require('models/auth_brokers/fx-desktop-v3'));

app/tests/spec/models/user.js

@@ -862,7 +862,7 @@ define(function (require, exports, module) {
         email: 'testuser@testuser.com',
         keyFetchToken: 'old-key-fetch-token',
         sessionToken: 'old-session-token',
-        sessionTokenContext: 'fx_desktop_v2',
+        sessionTokenContext: 'fx_desktop_v3',
         uid,
         unwrapBKey: 'old-unwrap-b-key',
       });

app/tests/spec/models/verification/same-browser.js

@@ -126,7 +126,7 @@ define(function (require, exports, module) {
 
       it('password reset, stores and loads verification keyed by email (pre-train-117)', function () {
         const persistModel = new SameBrowserVerificationModel({
-          context: 'fx_desktop_v2'
+          context: 'fx_desktop_v3'
         }, {
           email: 'testuser@testuser.com',
           namespace: 'context',
@@ -143,7 +143,7 @@ define(function (require, exports, module) {
         });
 
         loadModel.load();
-        assert.equal(loadModel.get('context'), 'fx_desktop_v2');
+        assert.equal(loadModel.get('context'), 'fx_desktop_v3');
       });
 
       it('password reset, stores and loads verification keyed by email, both uid and email specified in load (>= train-117)', function () {

server/lib/routes/get-index.js

@@ -47,7 +47,8 @@ module.exports = function (config) {
   }));
 
   const NO_LONGER_SUPPORTED_CONTEXTS = new Set([
-    'fx_desktop_v1'
+    'fx_desktop_v1',
+    'fx_desktop_v2'
   ]);
 
   return {

tests/functional.js

@@ -14,16 +14,12 @@ module.exports = [
   'tests/functional/sign_in_totp.js',
   'tests/functional/sign_in_recovery_code.js',
   'tests/functional/sync_v1.js',
+  'tests/functional/sync_v2.js',
   'tests/functional/sign_up.js',
   'tests/functional/complete_sign_in.js',
   'tests/functional/complete_sign_up.js',
   'tests/functional/connect_another_device.js',
   'tests/functional/send_sms.js',
-  'tests/functional/sync_v2_sign_up.js',
-  'tests/functional/sync_v2_sign_in.js',
-  'tests/functional/sync_v2_reset_password.js',
-  'tests/functional/sync_v2_settings.js',
-  'tests/functional/sync_v2_force_auth.js',
   'tests/functional/sync_v3_force_auth.js',
   'tests/functional/sync_v3_reset_password.js',
   'tests/functional/sync_v3_settings.js',

tests/functional/confirm.js

@@ -61,7 +61,7 @@ registerSuite('confirm', {
     },
 
     'sign up with a restmail address, get the open restmail button': function () {
-      var SIGNUP_URL = intern._config.fxaContentRoot + 'signup?context=fx_desktop_v2&service=sync';
+      var SIGNUP_URL = intern._config.fxaContentRoot + 'signup?context=fx_desktop_v3&service=sync';
       this.timeout = 90000;
 
       return this.remote

tests/functional/sync_v2.js

@@ -0,0 +1,70 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+'use strict';
+
+const { registerSuite } = intern.getInterface('object');
+const FunctionalHelpers = require('./lib/helpers');
+const selectors = require('./lib/selectors');
+const config = intern._config;
+
+const FORCE_AUTH_PAGE_URL = `${config.fxaContentRoot}force_auth?context=fx_desktop_v2&service=sync`;
+const SIGNIN_PAGE_URL = `${config.fxaContentRoot}signin?context=fx_desktop_v2&service=sync`;
+const SIGNUP_PAGE_URL = `${config.fxaContentRoot}signin?context=fx_desktop_v2&service=sync`;
+const RESET_PASSWORD_PAGE_URL = `${config.fxaContentRoot}reset_password?context=fx_desktop_v2&service=sync`;
+
+const {
+  clearBrowserState,
+  click,
+  openPage,
+  testElementExists,
+} = FunctionalHelpers;
+
+registerSuite('Firefox Desktop Sync v2', {
+
+  beforeEach: function () {
+    return this.remote
+      .then(clearBrowserState({ force: true }));
+  },
+
+  afterEach: function () {
+    return this.remote
+      .execute(() => {
+        // Opening about:blank aborts the Firefox download
+        // and prevents the tests from stalling when run on CentOS
+        window.location.href = 'about:blank';
+      });
+  },
+
+  tests: {
+    'force_auth': function () {
+      return this.remote
+        .then(openPage(FORCE_AUTH_PAGE_URL, selectors.UPDATE_FIREFOX.HEADER))
+        .then(click(selectors.UPDATE_FIREFOX.BUTTON_DOWNLOAD_FIREFOX))
+
+        .then(testElementExists(selectors.DOWNLOAD_FIREFOX_THANKS.HEADER));
+    },
+    'signin': function () {
+      return this.remote
+        .then(openPage(SIGNIN_PAGE_URL, selectors.UPDATE_FIREFOX.HEADER))
+        .then(click(selectors.UPDATE_FIREFOX.BUTTON_DOWNLOAD_FIREFOX))
+
+        .then(testElementExists(selectors.DOWNLOAD_FIREFOX_THANKS.HEADER));
+    },
+    'signup': function () {
+      return this.remote
+        .then(openPage(SIGNUP_PAGE_URL, selectors.UPDATE_FIREFOX.HEADER))
+        .then(click(selectors.UPDATE_FIREFOX.BUTTON_DOWNLOAD_FIREFOX))
+
+        .then(testElementExists(selectors.DOWNLOAD_FIREFOX_THANKS.HEADER));
+    },
+    'reset_password': function () {
+      return this.remote
+        .then(openPage(RESET_PASSWORD_PAGE_URL, selectors.UPDATE_FIREFOX.HEADER))
+        .then(click(selectors.UPDATE_FIREFOX.BUTTON_DOWNLOAD_FIREFOX))
+
+        .then(testElementExists(selectors.DOWNLOAD_FIREFOX_THANKS.HEADER));
+    }
+  }
+});