Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-scripts from 4.0.3 to 5.0.1+ #13147

Closed
data-sync-user opened this issue Jun 3, 2022 · 2 comments
Closed

Upgrade react-scripts from 4.0.3 to 5.0.1+ #13147

data-sync-user opened this issue Jun 3, 2022 · 2 comments
Labels
dependencies Pull requests that update a dependency file maintenance

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jun 3, 2022

Failed dependabot PR: https://github.com/mozilla/fxa/pull/12612

┆Issue is synchronized with this Jira Task

@data-sync-user data-sync-user added dependencies Pull requests that update a dependency file maintenance labels Jun 3, 2022
@LZoog
Copy link
Contributor

LZoog commented Jun 8, 2022

This is going to be tricky to upgrade because we need to use a package that lets us modify webpack configs on top of CRA that supports this version. We currently use rescripts, but that repo has been recently archived.

24|admin-r | 2022-06-03T13:06:45: (webpack)/buildin/global.js
24|admin-r | 2022-06-03T13:06:45: Error: ENOENT: no such file or directory, open ‘/Users/[user]/projects/fxa/node_modules/react-scripts/node_modules/webpack/buildin/global.js’

^This is rescripts attempting to look inside react-scripts for a webpack file that was moved to another path (unsure what path without looking) with the react-scripts upgrade. There doesn't seem to be a note or issue from the author.

CRACO could be another option, but the author is looking for a maintainer/lead and there's an existing issue to support this.

Also interesting readings in this CRA issue where the author of rescripts and CRACO commented.

We might need to replace rescripts with react-app-rewired, according to this closed issue they support CRA 5.

@cknowles-admin
Copy link

FxA is no longer synchronizing all issues between Jira and Github. We are closing open issues and will selectively synchronize in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

No branches or pull requests

3 participants