Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Accounts login screen displays "Account Settings" in English in different locales #15177

Open
bcolsson opened this issue Apr 14, 2023 · 2 comments

Comments

@bcolsson
Copy link
Contributor

bcolsson commented Apr 14, 2023

Description

When you log out of Firefox Accounts and choose to login with a separate account in non-English locales, the service name will display as "Account Settings" in English.

Steps to reproduce

  1. Logout of Firefox Accounts
  2. Change preferred website language to something other than English
  3. Go to Firefox Accounts login
  4. Choose Use a different account
  5. Observe "Account Settings" appears in English

Screenshot 2023-04-14 at 16 18 21

Expected result

  1. A localized name for "Account Settings" would display.

Environment

Appears in staging and production.

┆Issue is synchronized with this Jira Task

@pdehaan
Copy link
Contributor

pdehaan commented Apr 15, 2023

I too can reproduce locally w/ Japanese.
Screenshot 2023-04-14 at 5 15 54 PM

If I'm reading it correctly, that string is via https://github.com/mozilla/fxa-content-server-l10n/blob/445aa568432fba43bb87162d4e5be6d7057c0942/locale/ja/settings.ftl#L1096

And now that I know the .ftl id, we can grep for usage in this repo:

git grep -n "signin-subheader-without-logo-with-servicename" packages | cat

packages/fxa-settings/src/pages/Signin/en.ftl:12:signin-subheader-without-logo-with-servicename = Continue to { $serviceName }
packages/fxa-settings/src/pages/Signin/index.tsx:92:          subheadingWithCustomServiceFtlId="signin-subheader-without-logo-with-servicename"

It looks like Japanese is 99% translated, and there isn't some obvious looking service name style string missing in https://pontoon.mozilla.org/ja/firefox-accounts/all-resources/?status=missing.
Still trying to track back to where that serviceName is being passed from, although it might be defaulting from the Constants.RELIER_DEFAULT_SERVICE_NAME which maybe isn't being translated.

git grep -n "RELIER_DEFAULT_SERVICE_NAME" | cat

packages/fxa-content-server/app/scripts/lib/constants.js:74:  RELIER_DEFAULT_SERVICE_NAME: 'Account Settings',
packages/fxa-content-server/app/scripts/models/reliers/relier.js:106:    serviceName: t(Constants.RELIER_DEFAULT_SERVICE_NAME),
packages/fxa-content-server/app/scripts/views/ready.js:112:        Constants.RELIER_DEFAULT_SERVICE_NAME,
packages/fxa-content-server/app/tests/spec/views/mixins/service-mixin.js:73:        Constants.RELIER_DEFAULT_SERVICE_NAME
packages/fxa-settings/src/lib/constants.ts:76:  RELIER_DEFAULT_SERVICE_NAME: 'Account Settings',

Plus nothing immediately obvious to me re: translated "Account Settings" strings in this repo:

git grep "Account Settings" *.ftl | cat

packages/fxa-auth-server/lib/senders/emails/layouts/subscription/en.ftl:#  $accountSettingsUrl (String) - URL to Account Settings
packages/fxa-settings/src/pages/ConnectAnotherDevice/en.ftl:# This link cancels the process of connecting another device, and takes the user back to Account Settings

… or in the fxa-conten-server-l10n repo:

pwd # /Volumes/Dev/github/mozilla/fxa-content-server-l10n
git grep "Account Settings" | grep -v ":#" | cat
# no results

@bcolsson
Copy link
Contributor Author

I believe these could be older IDs. Searching in pontoon for
メールアドレスを入力
Only brings up gettext.
https://pontoon.mozilla.org/ja/firefox-accounts/all-resources/?search=メールアドレスを入力&string=169668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants