-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox Accounts login screen displays "Account Settings" in English in different locales #15177
Comments
I too can reproduce locally w/ Japanese. If I'm reading it correctly, that string is via https://github.com/mozilla/fxa-content-server-l10n/blob/445aa568432fba43bb87162d4e5be6d7057c0942/locale/ja/settings.ftl#L1096 And now that I know the .ftl id, we can grep for usage in this repo: git grep -n "signin-subheader-without-logo-with-servicename" packages | cat
packages/fxa-settings/src/pages/Signin/en.ftl:12:signin-subheader-without-logo-with-servicename = Continue to { $serviceName }
packages/fxa-settings/src/pages/Signin/index.tsx:92: subheadingWithCustomServiceFtlId="signin-subheader-without-logo-with-servicename" It looks like Japanese is 99% translated, and there isn't some obvious looking service name style string missing in https://pontoon.mozilla.org/ja/firefox-accounts/all-resources/?status=missing. git grep -n "RELIER_DEFAULT_SERVICE_NAME" | cat
packages/fxa-content-server/app/scripts/lib/constants.js:74: RELIER_DEFAULT_SERVICE_NAME: 'Account Settings',
packages/fxa-content-server/app/scripts/models/reliers/relier.js:106: serviceName: t(Constants.RELIER_DEFAULT_SERVICE_NAME),
packages/fxa-content-server/app/scripts/views/ready.js:112: Constants.RELIER_DEFAULT_SERVICE_NAME,
packages/fxa-content-server/app/tests/spec/views/mixins/service-mixin.js:73: Constants.RELIER_DEFAULT_SERVICE_NAME
packages/fxa-settings/src/lib/constants.ts:76: RELIER_DEFAULT_SERVICE_NAME: 'Account Settings', Plus nothing immediately obvious to me re: translated "Account Settings" strings in this repo: git grep "Account Settings" *.ftl | cat
packages/fxa-auth-server/lib/senders/emails/layouts/subscription/en.ftl:# $accountSettingsUrl (String) - URL to Account Settings
packages/fxa-settings/src/pages/ConnectAnotherDevice/en.ftl:# This link cancels the process of connecting another device, and takes the user back to Account Settings … or in the fxa-conten-server-l10n repo: pwd # /Volumes/Dev/github/mozilla/fxa-content-server-l10n
git grep "Account Settings" | grep -v ":#" | cat
# no results |
I believe these could be older IDs. Searching in pontoon for |
Description
When you log out of Firefox Accounts and choose to login with a separate account in non-English locales, the service name will display as "Account Settings" in English.
Steps to reproduce
Use a different account
Expected result
Environment
Appears in staging and production.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: