refactor(api): prefer async/await in session routes #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
philbooth
force-pushed
the
pb/2305-async-await-session
branch
5 times, most recently
from
bcf00ab
to
f903b07
Compare
philbooth
force-pushed
the
pb/2305-async-await-session
branch
from
f903b07
to
6a076b9
Compare
bbangert
reviewed
Sep 3, 2019
| // independent verification codes. | ||
| let newVerificationState = {}; | ||
| if (origSessionToken.tokenVerificationId) { | ||
| newVerificationState.tokenVerificationId = random.hex( |
There was a problem hiding this comment.
I assume these return promises? That's why there's P.props below? If so, why not await them here and avoid the P.props entirely?
There was a problem hiding this comment.
Yep. Just for efficiency I think, so they're awaited concurrently.
bbangert
approved these changes
Sep 3, 2019
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2305.
@mozilla/fxa-devs r?