New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(auth server): typescript lib/oauth/metrics #5161
Conversation
b780fa5
to
bc0db23
Compare
@@ -0,0 +1,11 @@ | |||
// This interface should be expanded on | |||
// as we slowly move over to TypeScript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually might be easier just change the config file to .ts
, install @types/convict
, and export typeof conf
in the config ts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many implications for changing the config file to typescript 😆
343b0ef
to
f82a7bd
Compare
If you add "[skip ci]" to your commit message of a wip commit, CircleCI will skip CI. |
@chenba fair, yeah, this config change has just been so far reaching that I'm using CI to find all the spots 😅 |
f82a7bd
to
86d7691
Compare
@chenba Okay, so we're passing now, but you'll notice I had to up certain timeouts an quite a bit. I'm guessing it has to do with mocha using TypeScript and needing to compile everything repeatedly. Or perhaps it's the use |
86d7691
to
0e37797
Compare
0e37797
to
97cf82e
Compare
Closes #4879
Part of a larger effort to adopt TypeScript in the Auth Server.
I'm trying to take a slow, educational approach to TypeScript, so please feel free to tear this apart.