Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #634: Provide a way to explore data via SQL query #1021

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

robhudson
Copy link
Member

@robhudson robhudson commented Nov 10, 2020

Screenshot_2020-11-10 gc_budget_overrun GLAM

@robhudson robhudson force-pushed the 634-data-exploration-sql branch 3 times, most recently from 89abd76 to 049f1ef Compare November 11, 2020 00:05
@robhudson robhudson requested a review from wlach November 11, 2020 00:09
@wlach
Copy link
Contributor

wlach commented Nov 12, 2020

I have a few concerns about this:

  1. (trivial) I don't think it will actually run, since we don't have a submission date filter?
  2. (more serious) I think we actually need to provide a starting point that people will find useful, rather than just a view of the raw data.

As is, I think this is just going to frustrate people, since in practice they'd need to go to #data-help to figure out what to do next (which might wind up being a very long and drawn out conversation). Earlier this year I wrote up this https://docs.telemetry.mozilla.org/cookbooks/main_ping_exponential_histograms.html which attempts to do this style of query on the main ping directly. Maybe we need to do an updated one that uses the GLAM tables and link to that as part of this interface? @acmiyaguchi, do you have any thoughts here?

@robhudson
Copy link
Member Author

robhudson commented Nov 12, 2020

(trivial) I don't think it will actually run, since we don't have a submission date filter?

They do run, I've tested them. There does need to be a bit of context, however, since the glam database has more history whereas the ETL tables only have current version plus 2 versions prior. So the results could have less data when compared to glam.

Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this a bit on Slack, and think this looks pretty reasonable as a starting point for feedback on other people on what they'd like to see. In that case, maybe the best thing to do is land it and then ask people directly for feedback. We can then adjust the messaging, add docs, etc., etc.

The code itself looks good to me, I don't really have any feedback at this stage. 👍

P.S. for future reference some results from this class of query are here:

https://sql.telemetry.mozilla.org/queries/76238/source

@robhudson robhudson merged commit 97376c2 into main Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants