Move dimension filters to body header; automatically select a process if current one is invalid; design tweaks to accomodate these changes #418
Conversation
| state.productDimensions.process | ||
| ) | ||
| ) { | ||
| let newProcess = probe.record_in_processes[0]; |
There was a problem hiding this comment.
Is it OK to always set it to the first item from the API? Perhaps we should default to parent.
There was a problem hiding this comment.
Not sure. From inspection, I found that parent is always the first if parent is available to the probe.
|
This brings our ESLint count down from 113 to 107. 🎉 |
hamilton
force-pushed
the
move-dimension-filters
branch
from
03c4db9
to
ba187c3
Compare
| @@ -243,6 +244,9 @@ h2 { | |||
| </div> | |||
| {/await} | |||
| </div> | |||
| <div class='drawer-section drawer-section--end'> | |||
| <Button level=low><Doc size={16} /> Documentation</Button> | |||
There was a problem hiding this comment.
This currently does nothing.
|
I think this brings a lot to the table. The new menu buttons have issues (can't immediately click into a new menu, cursor switches to default between clicks) but less issues than the old ones so not a blocker. I'd just either remove the doc link for now (or comment it out) until it does something...though I am not sure if the documentation is quite ready yet. r+wc |
…r dimensions for MainSelectors
…ut irrelevant keys in menus
… for greater control
hamilton
force-pushed
the
move-dimension-filters
branch
from
ed41554
to
37c6b6c
Compare
Closes #400, closes #401