Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach labels to categorical histograms #907

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Attach labels to categorical histograms #907

merged 1 commit into from
Sep 24, 2020

Conversation

robhudson
Copy link
Member

No description provided.

@robhudson robhudson force-pushed the 882-labels branch 2 times, most recently from ad0cb62 to 550b74d Compare September 23, 2020 15:26
@robhudson robhudson changed the base branch from rm-udgl to main September 23, 2020 15:28
@robhudson robhudson force-pushed the 882-labels branch 2 times, most recently from 99b8669 to 1db9b73 Compare September 23, 2020 21:30
@robhudson robhudson changed the title [wip] Attach labels to categorical histograms Attach labels to categorical histograms Sep 23, 2020
@robhudson robhudson marked this pull request as ready for review September 23, 2020 21:30
wlach
wlach approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this code area, but this looks reasonable! I have a minor suggestion on forEach vs. map.

src/config/firefox-desktop.js Outdated Show resolved Hide resolved
@robhudson robhudson merged commit 155ee8a into main Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlach wlach wlach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robhudson @wlach