Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a footer to each page #76

Closed
wlach opened this issue Oct 9, 2020 · 3 comments
Closed

Add a footer to each page #76

wlach opened this issue Oct 9, 2020 · 3 comments
Assignees

Comments

@wlach
Copy link
Contributor

wlach commented Oct 9, 2020

This issue is intended as an onboarding task for potential outreachy applicants. Please do not work on it unless you have completed the initial qualification task and it has been assigned to you.

GLAM has a footer element with some useful information at the bottom of each page:

image

We should have something similar for the Glean dictionary.

You can mostly copy over the existing footer from GLAM (putting it into the src/components/ directory) and then put it into each of the pages we display:

https://github.com/mozilla/glam/blob/77c4689297e3c81f6cf49f9fd6f73a9435d1761b/src/components/regions/Footer.svelte

Some styling should be adjusted and obviously the links should be different (e.g. the link to a slack channel should instead be a link to our channel on Matrix: https://chat.mozilla.org/#/room/#glean-dictionary:mozilla.org)

@wlach wlach added the outreachy label Oct 9, 2020
@wlach
Copy link
Contributor Author

wlach commented Oct 9, 2020

Going to assign this to @mridubhatnagar

@dharmelolar
Copy link

hello, @wlach please can I work on this?

@wlach
Copy link
Contributor Author

wlach commented Dec 3, 2020

We really need this sooner than later, so I'm going to take this over using @mridubhatnagar's excellent initial work as a base.

wlach added a commit that referenced this issue Dec 4, 2020
Based on earlier work by @mridubhatnagar (mridubhatnagar@rediffmail.com)
@wlach wlach closed this as completed in 94e27cf Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants