Bug 1677440 - Implement a ping uploader #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Jan 15, 2021
brizental
force-pushed
the
1677440-uploader
branch
2 times, most recently
from
0204fa5
to
500dc80
Compare
Dexterp37
requested changes
Jan 15, 2021
brizental
force-pushed
the
1677440-uploader
branch
from
500dc80
to
25586a2
Compare
Dexterp37
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there are no actual uploading tests in this PR. I thought it was big enough as it is.
Will write the remaning tests + implement a fetch API adapter while this review is going on.