Bug 1691068 - Implement log pings #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
1691068-log-pings
branch
from
9b3f13e
to
576f81a
Compare
brizental
commented
Feb 8, 2021
| Glean.instance._config!.debug = {}; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion |
There was a problem hiding this comment.
I should probably just disable this rule. I am not so against it. WDYT?
Dexterp37
requested changes
Feb 8, 2021
Dexterp37
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this was kinda neat so I am going to add videos to the description.
firefox-log-pings.mov
qt-log-pings.mov
Not only is it cool, but it helps us validate further the dispatcher PR as a side effect, since log pings relies on it. We know now that it works even in Qt.
Note: This is blocked until the dispatcher PR is merged.