Bug 1679375 - Implement a Storage that uses the web ext storage API #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
requested changes
Dec 7, 2020
brizental
force-pushed
the
1679375-storage-webext-no-tests
branch
3 times, most recently
from
c6179e9
to
8c4ae03
Compare
brizental
force-pushed
the
1679375-storage-webext-no-tests
branch
from
8c4ae03
to
223ee43
Compare
|
The check-size job will fail because it will try to run the new build:webext command on main which doesn't have it yet. I propose we ignore that failure for now. |
brizental
commented
Dec 8, 2020
brizental
changed the title
Dexterp37
requested changes
Dec 9, 2020
brizental
commented
Dec 9, 2020
brizental
commented
Dec 9, 2020
brizental
commented
Dec 9, 2020
brizental
commented
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split off of #7, containing only the storage implementation for web extensions. This doesnt contain tests as I am still figuring out last issue with testing direcly on browsers. This might mean that there are bugs on this implementation, but since I have done manual testing, no big changes should come on the tests PR and the overall approach will still be the same.