Bug 1679375 - Implement the base of the metrics database module #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Dec 10, 2020
|
FYI: CI didn't run for this PR, because it was not set up to run for PRs from forks. I changed that and it should run for next commits. |
Dexterp37
requested changes
Dec 14, 2020
brizental
commented
Dec 14, 2020
brizental
commented
Dec 14, 2020
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
brizental
force-pushed
the
1679375-database
branch
from
76213b1
to
dc85e0f
Compare
Dexterp37
approved these changes
Dec 14, 2020
| if (isObject(value)) { | ||
| console.error(`Unexpected value found for metric ${metric}: ${JSON.stringify(value)}. Clearing.`); | ||
| await store.delete([ping, metric.type, storageKey]); | ||
| return; |
There was a problem hiding this comment.
I'm still a bit puzzled by this, but we can revisit later: promises can be resolved or rejected, so maybe we can just assume that if it is resolved it has a value, otherwise rejected? Nothing to do now.
There was a problem hiding this comment.
Yeah, I considered just leaving the data there. But that would just mean this would fail until we record/transform again, because we leave the corrupted data there...
There was a problem hiding this comment.
We can keep up this discussion on the bug I opened to investigate the best behaviour for this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was described in the proposal, the database module will differ from the glean-core database module.
While it will serve as an abstraction layer over the underlying storage, it will also be the interface to retrive the ping / metric payload data from the storage. This is a bit easier for Glean.js, because the data is saved already in the format that is expected by the ping schema.
I will leave comments on the code about some doubts that lingered after I was finished with this implementation.