Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically identify LLVM gcno/gcda files by version #25

Closed
marco-c opened this issue Apr 28, 2017 · 2 comments
Closed

Automatically identify LLVM gcno/gcda files by version #25

marco-c opened this issue Apr 28, 2017 · 2 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented Apr 28, 2017

@jcranmer

@jcranmer
Copy link

LLVM uses 402* as its version string for the GCNO/GCDA version (probably because it was meant to be compatible with then-extant gcc on Apple systems, which would be gcc 4.2). Given that we're not likely to be running code that old on gcc (even when I started 7 years ago, we were on gcc 4.4 on Linux), using 402* versus newer versions seems to make sense.

@marco-c
Copy link
Collaborator Author

marco-c commented Apr 28, 2017

This is great, thanks. It will solve the problem of builds that mix LLVM and GCC (that is, mozilla-central with Rust code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants