Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IPv4 addresses when ENFORCE_HOST is set #3340

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Allow IPv4 addresses when ENFORCE_HOST is set #3340

merged 1 commit into from
Sep 30, 2018

Conversation

pmac
Copy link
Member

@pmac pmac commented Sep 28, 2018

Fix #2998

@pmac pmac requested a review from jgmize September 28, 2018 19:47
@pmac pmac force-pushed the allow-ip-addresses-enforce-host branch 2 times, most recently from b43a2ae to 2f2a901 Compare September 28, 2018 19:59
@pmac pmac force-pushed the allow-ip-addresses-enforce-host branch from 2f2a901 to 10e216c Compare September 28, 2018 20:39
@pmac
Copy link
Member Author

pmac commented Sep 28, 2018

The app we use for the redirects doesn't strip the port from the host for checking, so support.mozilla.org:8080 would redirect. This isn't a big deal, but I did file a PR to fix this:

dabapps/django-enforce-host#1

jgmize
jgmize approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@jgmize jgmize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @pmac. The circleci failure was during the DB teardown after the tests all passed, so this looks good to merge.

@jgmize jgmize merged commit d622d4f into mozilla:master Sep 30, 2018
This was referenced Sep 30, 2018
Closed
Merged
@pmac pmac deleted the allow-ip-addresses-enforce-host branch October 1, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmize jgmize jgmize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmac @jgmize