Adding search class for simplesearch #3417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SimpleSearch
class for building theSearch
object of simple search.So it should work something like this
I have tried to follow factory pattern in
SimpleSearch
, but dont know if totally follow the factory pattern.This class can be used in
simple_search
view to build the Search object then paginate and execute. Need to be verified that all the boosting are correct and fields are covered according to previousgenerate_simple_search
function.Highlight and others are not added yet.
This will made following elasticsearch query. Looking at the json, I think it make sense. Maybe we can compare the old elasticsearch query with this query.
@pmac r?