Integrating with simplesearch view and fix the tests #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re #3294 |
pmac
reviewed
Dec 20, 2018
| @@ -32,10 +32,15 @@ class UntypedS(object): | |||
| def F(*args, **kwargs): | |||
| pass | |||
|
|
|||
|
|
|||
| def get_es(): | |||
There was a problem hiding this comment.
We should at least have this print a warning or something. It still needs to go away entirely.
There was a problem hiding this comment.
Maybe can add a comment with TODO:
| @@ -178,7 +178,7 @@ def unindex_task(cls, id_list, **kw): | |||
| @task() | |||
| @timeit | |||
| def update_synonyms_task(): | |||
| es = get_es() | |||
| es = get_es() # noqa | |||
There was a problem hiding this comment.
Is this being ignored by flake8 because it's not imported? I don't think we should paper over it like this as we might forget to remove it later.
There was a problem hiding this comment.
Yeah. I think I can add a comment here with TODO: to remove it.
I dont know any other easy way to make the flake8 happy for this.
|
Going ahead and merging this so that you can continue with the ES work. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will integrate
SimpleSearch(implemented in #3417) with thesimple_searchview. All the tests ofsimple_searchview seems to be passing! 馃挴Maybe we have progress one step towards upgrading to Elasticsearch 6.x! 馃槃
@pmac what do you think?