Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all /en-US/ links from non en-US pages #223

Closed
pdehaan opened this issue Sep 8, 2014 · 1 comment
Closed

Remove all /en-US/ links from non en-US pages #223

pdehaan opened this issue Sep 8, 2014 · 1 comment

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Sep 8, 2014

via #202 (comment)

I'm proposing that all links should be de-localed so if I happen to be on a bn-BD privacy notice page and click a link, I wouldn't be taken to an en-US privacy policy doc (if a bn-BD translation was potentially available). For example:

[Mozilla গোপনীয়তা নীতি পড়ুন](http://www.mozilla.org/en-US/privacy/)

I think those links should just be tweaked to something like this, and let the site handle the redirect based on the user's current locale (or the best fallback, which may be en-US):

[Mozilla গোপনীয়তা নীতি পড়ুন](https://www.mozilla.org/privacy/)

Here was a list of all the files I could find in the legal-docs repo that mention "/en-US/" but weren't an en-US.md file:

$ grep -irl "/en-us/" . | grep -iv en-US.md$

./firefox_cloud_services_ToS/cs.md
./firefox_cloud_services_ToS/de.md
./firefox_cloud_services_ToS/el.md
./firefox_cloud_services_ToS/es.md
./firefox_cloud_services_ToS/fr.md
./firefox_cloud_services_ToS/hi.md
./firefox_cloud_services_ToS/hr.md
./firefox_cloud_services_ToS/hu.md
./firefox_cloud_services_ToS/it.md
./firefox_cloud_services_ToS/ja.md
./firefox_cloud_services_ToS/mk.md
./firefox_cloud_services_ToS/pl.md
./firefox_cloud_services_ToS/pt-BR.md
./firefox_cloud_services_ToS/ru.md
./firefox_cloud_services_ToS/sr-LATN.md
./firefox_cloud_services_ToS/ta.md
./firefox_cloud_services_ToS/zh-CN.md

./firefox_os_privacy_notice/bn-BD.md
./firefox_os_privacy_notice/bn-IN.md
./firefox_os_privacy_notice/cs.md
./firefox_os_privacy_notice/fr.md
./firefox_os_privacy_notice/hi.md
./firefox_os_privacy_notice/hr.md
./firefox_os_privacy_notice/ja.md
./firefox_os_privacy_notice/mk.md
./firefox_os_privacy_notice/ru.md
./firefox_os_privacy_notice/ta.md

./heartbleed_privacy_notice_en.US.md

./marketplace_developer_agreement/bn-BD.md
./marketplace_developer_agreement/bn-IN.md
./marketplace_developer_agreement/cs.md
./marketplace_developer_agreement/el.md
./marketplace_developer_agreement/es.md
./marketplace_developer_agreement/fr.md
./marketplace_developer_agreement/hi.md
./marketplace_developer_agreement/hr.md
./marketplace_developer_agreement/hu.html
./marketplace_developer_agreement/hu.md
./marketplace_developer_agreement/ja.md
./marketplace_developer_agreement/mk.md
./marketplace_developer_agreement/pl.md
./marketplace_developer_agreement/pt-BR.md
./marketplace_developer_agreement/ru.md
./marketplace_developer_agreement/sr.md
./marketplace_developer_agreement/ta.md
./marketplace_developer_agreement/zh-CN.md

./marketplace_privacy_policy/bn-BD.md
./marketplace_privacy_policy/bn-IN.md
./marketplace_privacy_policy/cs.md
./marketplace_privacy_policy/de.md
./marketplace_privacy_policy/es.md
./marketplace_privacy_policy/fr.md
./marketplace_privacy_policy/hi.md
./marketplace_privacy_policy/hr.md
./marketplace_privacy_policy/hu.md
./marketplace_privacy_policy/it.md
./marketplace_privacy_policy/ja.md
./marketplace_privacy_policy/mk.md
./marketplace_privacy_policy/pl.md
./marketplace_privacy_policy/ru.md
./marketplace_privacy_policy/sr.md
./marketplace_privacy_policy/ta.md
./marketplace_privacy_policy/zh-CN.md

./marketplace_terms_of_use/bn-BD.md
./marketplace_terms_of_use/bn-IN.md
./marketplace_terms_of_use/cs.md
./marketplace_terms_of_use/fr.md
./marketplace_terms_of_use/hi.md
./marketplace_terms_of_use/hr.md
./marketplace_terms_of_use/hu.md
./marketplace_terms_of_use/it.md
./marketplace_terms_of_use/ja.md
./marketplace_terms_of_use/mk.md
./marketplace_terms_of_use/ru.md
./marketplace_terms_of_use/sr.md
./marketplace_terms_of_use/ta.md
./marketplace_terms_of_use/zh-CN.md

./Mobile_Partner_Website_Branding_Terms/zh-CN.md

./mozilla_privacy_policy/bn-IN.md
./mozilla_privacy_policy/cs.md
./mozilla_privacy_policy/de.md
./mozilla_privacy_policy/es.md
./mozilla_privacy_policy/fr.md
./mozilla_privacy_policy/hi.md
./mozilla_privacy_policy/hr.md
./mozilla_privacy_policy/hu.md
./mozilla_privacy_policy/mk.md
./mozilla_privacy_policy/pl.md
./mozilla_privacy_policy/ru.md
./mozilla_privacy_policy/sr.md
./mozilla_privacy_policy/ta.md
./mozilla_privacy_policy/zh-CN.md

./README.md
@pdehaan pdehaan mentioned this issue Sep 8, 2014
@pdehaan
Copy link
Contributor Author

pdehaan commented Sep 9, 2014

Probably just a dupe of #185

@pdehaan pdehaan closed this as completed Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant