Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

automated code coverage, static analysis, fuzzing, style checking, etc. #25

Closed
rhelmer opened this issue Aug 28, 2018 · 2 comments
Closed

Comments

@rhelmer
Copy link
Contributor

rhelmer commented Aug 28, 2018

Now that Travis CI is running it'd be pretty easy to add things like test coverage, static analysis tools (clang-tidy and scan-build are OK, there are more), fuzzing, style checking etc.

I know that there is a particular code style already in-place for libprio but I'd very much suggest that some out-of-the-box style using clang-format be used (it comes with a Mozilla style even!) and enforced when PRs are opened. More for the sake of future contributors than as a personal preference (but that too ;)

@henrycg
Copy link
Collaborator

henrycg commented Aug 28, 2018

Using clang-format to enforce the Mozilla C style (or whatever other standard style) sounds like a great idea.

rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 28, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 29, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 29, 2018
rhelmer added a commit that referenced this issue Aug 29, 2018
* issue #25 - format libprio with clang-format, using Mozilla style

* force clang 3.9 (latest available on Ubuntu Trusty)

* remove clang-format file, 3.9 is confused by some settings. try using built-in Mozilla style instead
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 30, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 30, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 30, 2018
rhelmer added a commit to rhelmer/libprio-1 that referenced this issue Aug 30, 2018
henrycg added a commit that referenced this issue Aug 30, 2018
issue #25 - use clang as the compiler
@rhelmer
Copy link
Contributor Author

rhelmer commented Sep 17, 2018

We have CI now with compilation, tests, and clang-format. Static analysis and fuzzing are pretty complex and probably worth leaving to Firefox and not try to get it going in Travis-CI right now.

@rhelmer rhelmer closed this as completed Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants