This Firefox-specific browser test was moved to a unit test in https:…

[rhelmer]

…//bugzilla.mozilla.org/show_bug.cgi?id=1485620 so we can remove it now

@henrycg would you mind making sure I didn't miss anything in the conversion to the gtest ^? Thanks!

[rhelmer]

Carrying over the conversation in https://phabricator.services.mozilla.com/D6049#136547:

It might be slightly cleaner to move all of the server-side validation logic in TestPrioEncoder.cpp into libprio, since the server-side logic is not what we want to test here. (Also, if we end up having to tweak the server-side APIs down the road, it would be nice if we didn't have to change the browser tests too.)

If you think that this would be a good idea, we would implement a test function in libprio that takes as input:

the PrioConfig,
the two server private keys, and
the two ciphertexts generated by the browser.

The test function would run the server-side validation logic and would then spit out the plaintext data as an array of booleans. Then in TestPrioEncoder.cpp, we would just create the two keypairs, generate the ciphertext using PrioEncoder.Encode, use a single call to the test function to decode the ciphertexts, and check that the recovered plaintext array matches the array given to PrioEncoder.

If that makes sense to you, I can put together a patch for libprio that implements this function.

I have mixed feelings - this doesn't seem like too much to me and it's well-commented so might be nice to have as an example, but having a higher-level API in libprio would be nice too

[henrycg]

Looks good to me.

[henrycg]

Let's leave it as is then. Getting browser-test out of libprio is great and if we end up needing to change the server-side API later on, we can always revisit this.