Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Linux distros expect NSS headers to not have nss/ prefix on include, … #40

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Linux distros expect NSS headers to not have nss/ prefix on include, … #40

merged 3 commits into from
Sep 17, 2018

Conversation

rhelmer
Copy link
Contributor

@rhelmer rhelmer commented Sep 17, 2018

@rhelmer
Copy link
Contributor Author

rhelmer commented Sep 17, 2018

Note that I haven't actually tested this on Linux yet, with SCons :) We may need to add the include path explicitly as nspr is now.

@rhelmer
Copy link
Contributor Author

rhelmer commented Sep 17, 2018

Oh, right, Travis-CI has my back on the Linux testing.

@rhelmer rhelmer self-assigned this Sep 17, 2018
henrycg
henrycg approved these changes Sep 17, 2018
View reviewed changes
Copy link
Collaborator

@henrycg henrycg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Linux and Mac.

@rhelmer rhelmer merged commit 488da2d into mozilla:master Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@henrycg henrycg henrycg approved these changes

Assignees

@rhelmer rhelmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhelmer @henrycg