This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Ensure that early cleanup runs correctly #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrycg
suggested changes
Feb 14, 2019
|
I took a quick look, looks like it's some header issue... not sure why it's cropping up again, will take a closer look. |
|
Oh, it's failing because the version of NSS we're downloading (straight from the FTP archive since we want a newer one than available in the Travis-provided distro) doesn't exist, but the CI script doesn't catch that. I'll fix it and also tighten up the error checking in the script. |
rhelmer
force-pushed
the
ensure-early-cleanup-runs
branch
from
a34a4fd
to
93e9ae6
Compare
henrycg
approved these changes
Feb 14, 2019
|
Looks good to me! Thanks for making this fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.