Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Bug 1231702 - Speedup build by only transpiling changed jsx files #19

Merged
merged 1 commit into from
Jan 6, 2016

Conversation

dmose
Copy link
Member

@dmose dmose commented Dec 17, 2015

This is a somewhat gross, but probably appropriately so for this moment, WIP patch. It's already cut a bunch of seconds off the build time and needs some cleanup before I can submit it for review.

@dmose dmose force-pushed the jsx-build-1231702 branch 3 times, most recently from ed5ea76 to 10572c8 Compare January 5, 2016 19:07
@dmose dmose changed the title WIP Makefile pull request Bug 1231702 - Speedup build by only transpiling changed jsx files Jan 5, 2016
@dmose
Copy link
Member Author

dmose commented Jan 5, 2016

Right now, on my machine (Macbook Pro, 2.8Ghz i7 with 8 cores), a clean build on master takes
8+ seconds, and a subsequent build touching a shared/js/views.jsx file takes 5+ seconds.

This commit changes a clean build to take 14+ seconds, and a subsequent build touching shared/js/views.jsx to take 2.5 seconds, add-ons/panels/js/panel.jsx 1.2 seconds, and a patch touching add-on/panels/js/roomStore.js only 0.4 seconds.

There is room to try various other optimizations in the future, such as not compiling stuff in shared 3 times, as well as whatever else can be found by profiling, but this seems like a good start for the most common cases.

$(BUILT)/standalone/content/shared/js:
mkdir -p $@

# We can't used $(shared_jsx_files) here because % rules don't accept that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/used/use/ (several places)

@Standard8
Copy link
Member

r=Standard8 with the comments addressed.

dmose pushed a commit that referenced this pull request Jan 6, 2016
Bug 1231702 - Speedup build by only transpiling changed jsx files, r=Standard8
@dmose dmose merged commit 85cb1d9 into mozilla:master Jan 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants