This repository has been archived by the owner on Dec 1, 2017. It is now read-only.
Bug 1210754 - Use InitPublisher completion handler callbacks for hand… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveccrit
force-pushed
the
1210754-initPublisher
branch
from
a63c7e0
to
86bf844
Compare
| sinon.assert.calledOnce(driver._onScreenSharePublishComplete); | ||
| }); | ||
|
|
||
| it("should call onScreenSharePublishError from onScreenSharePublishComplete on error", function() { |
There was a problem hiding this comment.
nit: indentation (the entire "it" here is too far indented).
daveccrit
force-pushed
the
1210754-initPublisher
branch
4 times, most recently
from
c46e0d2
to
866fbfc
Compare
| @@ -159,6 +161,58 @@ describe("loop.OTSdkDriver", function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("#initPublisherComplete", function() { | |||
There was a problem hiding this comment.
Ok, I missed this before. Can you merge this describe("#initPublisherComplete") with the previous one describe("setupStreamElements").
Bascially you want to end up with one describe for setupStreamElements, and move the beforeEach to the top of the describe.
daveccrit
force-pushed
the
1210754-initPublisher
branch
2 times, most recently
from
8871290
to
b270067
Compare
…ling getUserMedia errors r=standard8
daveccrit
force-pushed
the
1210754-initPublisher
branch
from
b270067
to
30805b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ling getUserMedia errors