Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Bug 1231931 - Split string files into add-on, shared, standalone files #5

Closed
wants to merge 2 commits into from
Closed

Bug 1231931 - Split string files into add-on, shared, standalone files #5

wants to merge 2 commits into from

Conversation

chrafuse
Copy link
Contributor

No description provided.

Standard8
Standard8 reviewed Dec 11, 2015
View reviewed changes
locale/en-US/shared.properties
tos_failure_message={{clientShortname}} is not available in your country.

unmute_local_audio_button_title=Unmute your audio
unmute_local_video_button_title2=Enable video
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the unmutes next to the mute options above.

Also, please ensure there is a new line at the end of the file.

@Standard8
Copy link
Member

Looks good. I'd suggest the commit message for the first one changes from "Strings splint into 3 files" to "Incorporate desktop strings and split into multiple files".

@Mardak
Copy link
Member

Mardak commented Dec 16, 2015

This landed as 4628886

@chrafuse next time if you push the rebased commits to the branch on your fork, it'll auto-close this pull request.

@Mardak Mardak closed this Dec 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrafuse @Standard8 @Mardak