This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Change to new search api #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ define('routes_api', [], function() { | |||
| 'fxa-login': '/api/v2/account/fxa-login/', | |||
| 'login': '/api/v2/account/login/', | |||
| 'logout': '/api/v2/account/logout/', | |||
| 'search': '/api/v1/apps/search/suggest/non-public/?cache=1&vary=0', | |||
| 'search': '/api/v1/apps/search/non-public/?cache=1&vary=0', | |||
There was a problem hiding this comment.
Maybe name it lookup, if you still plan on this being the basis of a future lookup tool API?
There was a problem hiding this comment.
I was thinking about lookup b/c of the suggest api but not sure anymore. I suppose it still could be. But even so the lookup needs to find deleted apps and this one doesn't so I'll likely just end up using the same API endpoint and requiring new permissions. But now with the search DRF filters it makes this super easy.
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.