Skip to content
This repository has been archived by the owner on Oct 23, 2019. It is now read-only.

Fix plan formset handling in new contribution frontend. #93

Merged
merged 2 commits into from
Feb 25, 2015
Merged

Fix plan formset handling in new contribution frontend. #93

merged 2 commits into from
Feb 25, 2015

Conversation

johngian
Copy link
Contributor

  • On load, show plans if button is checked.
  • Let users know it there are any errors if button is checked.
  • Fix broken behaviour in formsets when checkbox is checked.

@johngian
Fix plan formset handling in new contribution frontend.
776f118 
* On load, show plans if button is checked.
* Let users know it there are any errors if button is checked.
* Fix broken behaviour in formsets when checkbox is checked.
@johngian
Copy link
Contributor Author

@akatsoulas r?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.17% when pulling 776f118 on johngian:fix-checked-formsets into d02e599 on mozilla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.17% when pulling 776f118 on johngian:fix-checked-formsets into d02e599 on mozilla:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.17% when pulling bba1245 on johngian:fix-checked-formsets into d02e599 on mozilla:master.

comzeradd
comzeradd reviewed Feb 25, 2015
View reviewed changes
marketpulse/main/static/js/price_new.js
} else {
$(this).closest('.planprices').find('.hasplan').show();
choice.hide();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could also amend the displayLocationForm function a few lines above, to use the same style of code as this. It seems more clear the way you implemented it.

@comzeradd
Copy link
Contributor

r+wc 🚀

johngian added a commit that referenced this pull request Feb 25, 2015
@johngian
Merge pull request #93 from johngian/fix-checked-formsets
62e57a9 
Fix plan formset handling in new contribution frontend.
@johngian johngian merged commit 62e57a9 into mozilla:master Feb 25, 2015
@johngian johngian deleted the fix-checked-formsets branch February 25, 2015 15:15
@akatsoulas akatsoulas mentioned this pull request Feb 26, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johngian @coveralls @comzeradd