This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Remove contribute signup tests. Fix #428 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could skip or xfail, too, but removing and then revisiting this coverage -- whether here and/or in https://github.com/mozilla/bedrock/blob/master/tests/functional/contribute-signup.js also makes sense, so r+'ing and merging to fix bustage due to A/B testing. |
stephendonner
added a commit
that referenced
this pull request
Jul 22, 2015
Remove contribute signup tests. Fix #428
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are failing intermittently due to A/B tests. Once the A/B tests are complete, we will most likely need to write new tests as part of the permanent change to the the /contribute/signup/ page. If no permanent changes to the pages are justifiable based on the A/B test data, we can revert this commit to restore the original tests.