This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Parameterize the l10n download link tests #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adhoc: http://webqa-ci-staging1.qa.scl3.mozilla.com:8080/job/mozorg.adhoc/32/ Before: 122 tests ran in 151 seconds |
|
@bobsilverberg would you mind taking a look at this and giving feedback? |
| @@ -7,74 +6,47 @@ | |||
| import pytest | |||
| import requests | |||
|
|
|||
| pytestmark = [pytest.mark.nondestructive, pytest.mark.skip_selenium] | |||
There was a problem hiding this comment.
Nice. I didn't know about pytestmark.
There was a problem hiding this comment.
Neither did I. For reference, here are the docs: https://pytest.org/latest/example/markers.html#marking-whole-classes-or-modules
|
Very nice, @davehunt, I like it! r+ wc |
|
This was merged in 2e60764 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on pull #438 so should be held until that's merged. It removes existing duplication (tests/test_l10n_download_links.py and tests/test_localization.py appear to check the same things) but also refactors the tests to be parameterised. This allows for better use of resources as we can run the individual tests in parallel, and provides a better representation of coverage and failures. It also means that when running these tests locally you get regular feedback, rather than individual tests running for several minutes without reporting anything to the console.