This repository has been archived by the owner on Sep 14, 2019. It is now read-only.
Bug 104714: implement HasIPConnected on Darwin #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,8 +64,104 @@ func HasSeenMac(val string) (found bool, elements []element, err error) { | |||
| return | |||
| } | |||
|
|
|||
| func parseEndpointString(str string) (ip net.IP, port int) { | |||
| re, err := regexp.Compile("^(.*?)(%[a-z0-9]+)?\\.(\\*|[0-9]+)$") | |||
There was a problem hiding this comment.
It'd be nice to not re-compile this regexp every time -- tips?
There was a problem hiding this comment.
You could define it as a global variable, since the regexp is static:
package main
import (
"fmt"
"regexp"
)
var re = regexp.MustCompile("^$")
func main() {
if re.MatchString("test") {
fmt.Println("test doesn't match")
}
if re.MatchString("") {
fmt.Println("empty string matches")
}
}
|
@jvehent pointed out http://stackoverflow.com/questions/5390164/getting-routing-table-on-macosx-programmatically -- not sure that's worth the effort.. |
| func parseEndpointString(str string) (ip net.IP, port int) { | ||
| re, err := regexp.Compile("^(.*?)(%[a-z0-9]+)?\\.(\\*|[0-9]+)$") | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
I would recommend not panicking directly, but instead return an error value here, or panic and recover.
|
Looks good. Just a couple minors. |
|
OK, those should be fixed up - let me know what you think |
|
Looks good. r+ |
jvehent
added a commit
that referenced
this pull request
Mar 17, 2015
Bug 104714: implement HasIPConnected on Darwin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by hand on OS X 10.8.
I did run into some trouble, indicated by the comments inline, where netstat produces a truncated ipv6 address. I don't have any idea how to fix that, or if it's even possible.