Add support for web extension messages.json & plain key-value JSON files #2
Conversation
eemeli
changed the title
|
Also added nested key-value JSON files. |
| from .parse import plain_parse | ||
| from .serialize import plain_serialize | ||
|
|
||
| __all__ = ["plain_parse", "plain_serialize"] |
There was a problem hiding this comment.
The name of the folder doesn't reflect the name of the format (json) as is the case with other formats.
I expect that to result in confusion when searching for the relevant code.
There was a problem hiding this comment.
That was an intentional choice, to account for the possibility of this structure working with other resource formats, such as YAML.
| from .parse import webext_parse | ||
| from .serialize import webext_serialize | ||
|
|
||
| __all__ = ["webext_parse", "webext_serialize"] |
There was a problem hiding this comment.
Same as with the plain JSON support - I would expect the name to include the word json.
| "placeholders", | ||
| "1your_name", | ||
| "content", | ||
| ], |
There was a problem hiding this comment.
Interesting, I didn't even realize Pontoon already supports multiple nesting levels in key-value JSON files. Just checked and... it does.
| ["placeholders"], | ||
| PatternMessage( | ||
| [ | ||
| "Hello$$ ", |
There was a problem hiding this comment.
It puzzles me why is this not "Hello$$$ ".
There was a problem hiding this comment.
From here:
Any number of consecutive dollar signs appearing in strings are replaced by the same number of dollar signs minus one. So,
$$>$,$$$>$$, etc.
|
I'm going to keep the paths for now, and iterate on them later as the whole shape of this comes into clearer focus. We could e.g. end up with |
The parser and serialiser are pretty strict for this, as the
messages.jsonformat is pretty explicit. It also effectively requires using the MF2 data model representation, does not allow for metadata, and is also pretty strict on the keys it supports.