Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving group durations in the treeherder_client data source #662

Open
marco-c opened this issue Feb 23, 2022 · 2 comments
Open

Comments

@marco-c
Copy link
Collaborator

marco-c commented Feb 23, 2022

The group duration data is not yet available in Treeherder, when it is available we should support retrieving it in the treeherder data source when implementing the test_task_groups data contract.

@marco-c marco-c assigned marco-c and unassigned marco-c Feb 23, 2022
marco-c added a commit to marco-c/mozci that referenced this issue Feb 23, 2022
marco-c added a commit to marco-c/mozci that referenced this issue Feb 23, 2022
marco-c added a commit that referenced this issue Feb 26, 2022
…ement summarizing durations without ActiveData (#663)

* Support retrieving group durations in the errorsummary data source

The treeherder_client data source should support it too, but the data is not available yet
in Treeherder, so for now it will just return None so we don't have to split the contract in two.

Fixes #646

* Mention #662 in TODO comments for future cleanup

* Support GroupSummary durations using data from results

* Implement __make_group_summary_objects using data from group results

Fixes #359

* Update tests

* Update more tests

* Remove integration tests depending on ActiveData

Reinstating them without relying on ActiveData is tracked in #390

* Remove references to adr and ActiveData from the documentation

* Remove adr dependency

* Remove last references to ActiveData from code comments

* Install cache extras for tests as it is now required

Previously we were relying on adr depending on boto3
@jmaher
Copy link
Contributor

jmaher commented Jun 18, 2024

is this something we can close?

@marco-c
Copy link
Collaborator Author

marco-c commented Jun 19, 2024

Still not done:

# TODO: Once https://github.com/mozilla/mozci/issues/662 is fixed, we should return the actual duration instead of None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants