Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thunderbird daily default branch handling (#247) #676

Merged
merged 18 commits into from
May 8, 2024
Merged

Add Thunderbird daily default branch handling (#247) #676

merged 18 commits into from
May 8, 2024

Conversation

piri-p
Copy link
Contributor

@piri-p piri-p commented May 3, 2024

Fix #247 - Add Thunderbird daily default branch handling @whimboo
Also handle Firefox, Tinderbox

Test cases added

@piri-p piri-p changed the title Issue 247 thunderbird default branch Add Thunderbird daily default branch handling (#247) May 3, 2024
@piri-p
Copy link
Contributor Author

piri-p commented May 6, 2024

I noticed the pylama failure code due to pycodestyle (too long line) - fixed now by latest push

whimboo
whimboo requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Functionality wise this works fine. Please see my inline comments for further suggestions.

mozdownload/scraper.py Outdated Show resolved Hide resolved
mozdownload/scraper.py Show resolved Hide resolved
tests/daily_scraper/test_daily_scraper.py Outdated Show resolved Hide resolved
tests/tinderbox_scraper/test_tinderbox_scraper.py Show resolved Hide resolved
whimboo
whimboo reviewed May 6, 2024
View reviewed changes
mozdownload/cli.py Outdated Show resolved Hide resolved
@piri-p
Copy link
Contributor Author

piri-p commented May 6, 2024

Updated: Remove redundant test arguments, remove default branch from CLI, remove non-ops if-else block, add NotSupportedError and test cases for invalid branch @whimboo

@piri-p piri-p requested a review from whimboo May 6, 2024 13:35
whimboo
whimboo requested changes May 7, 2024
View reviewed changes
mozdownload/scraper.py Outdated Show resolved Hide resolved
tests/daily_scraper/test_daily_scraper.py Outdated Show resolved Hide resolved
@piri-p
Copy link
Contributor Author

piri-p commented May 7, 2024

Done, branch check commit reverted and test cases re-ordered @whimboo

@piri-p piri-p requested a review from whimboo May 7, 2024 21:43
whimboo
whimboo approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It looks all fine now and tests are passing as well.

@whimboo whimboo merged commit 5ccbc47 into mozilla:master May 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default branch for Thunderbird should be comm-central and not mozilla-central
2 participants
@piri-p @whimboo